Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 compatibility #66

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Conversation

katafrakt
Copy link
Contributor

Due to some changes in Ruby 3, rb-gsl does not compile for this version. This PR:

  • Adds 3.0 and all other minor versions to Travis
  • Changes EXTERN to extern
  • Solves issues around RBGSL_SET_CLASS0 and subtle change of behaviour in Ruby 3
  • Takes care of Ruby 3 redefining memcpy, which broke some macros

@katafrakt
Copy link
Contributor Author

Interesting thing: the tests on CI and my local Linux machine passed, but when I ran it on Mac, it failed and I had to add extra commit ffad864. This probably mean that CI could be better configured (perhaps it'd be enough to also run tests on MacOS) - but first the project needs to transition from travis-ci.org to travis-ci.com.

@david-macmahon
Copy link
Contributor

FWIW, I think there was some kerfuffle recently about Travis changing their policies regarding "free" use for open source projects. A number of projects switched to GitHub Actions for CI in response to that. I'm not sure how relevant that is here, but thought I'd mention it.

@prasunanand prasunanand merged commit 103a3e1 into SciRuby:master Sep 7, 2021
@prasunanand
Copy link
Member

Hi @katafrakt Would you like to be a maintainer of rb-gsl ?

cc: @v0dro @pjotrp @mrkn @translunar

@katafrakt
Copy link
Contributor Author

@prasunanand Not gonna lie: I know close to nothing about GSL, only I use it as dependency of classifier-reborn. But I could help on the Ruby side I guess, if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants